CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

Make status bar an actual divider

Open xyzqm opened this issue 1 year ago • 4 comments

Description

Previously, the status bar was just attached to the bottom of the editor, whereas in Xcode, it acts essentially as a thick divider. This PR aims to get the status bar to be more like Xcode's.

Relevant SO article: https://stackoverflow.com/questions/40643604/can-i-use-a-custom-view-as-a-nssplitviews-divider/40659541

Related Issues

  • Fixes #1729

Checklist

  • [ ] fix bug detailed in video below
  • [ ] get maximization/collapse buttons to work
  • [ ] I read and understood the contributing guide as well as the code of conduct
  • [ ] The issues this PR addresses are related to each other
  • [ ] My changes generate no new warnings
  • [ ] My code builds and runs on my machine
  • [ ] My changes are all related to the related issue above
  • [ ] I documented my code

Screenshots

As shown in the video below, normal drags + collapsing the editor work fine, but for some reason collapsing the terminal causes really jank behavior.

https://github.com/CodeEditApp/CodeEdit/assets/65467530/2beabea9-362b-40d4-88f8-3efafbeeaaec

xyzqm avatar May 22 '24 21:05 xyzqm

Does this include your work with #1701? I noticed that it was closed.

austincondiff avatar May 23 '24 15:05 austincondiff

Yes, the goal is to eventually integrate the changes from #1701, but I want to iron out the status bar first.

xyzqm avatar May 23 '24 16:05 xyzqm

@danielzsh Any updates on the status? Is this still in progress?

tom-ludwig avatar Aug 14 '24 12:08 tom-ludwig

Haven't worked on it in a while since it was way too hard to get working :( I tried two approaches:

  1. making the divider thick and drawing the status bar over it and
  2. having 3 views in the split, with the middle one being the status bar But they both led to very jank results (which I can't quite recall at the moment).

xyzqm avatar Aug 14 '24 18:08 xyzqm

I don't think this is necessary anymore with the recent changes we've made to the utility area. Thanks so much for the effort @danielzsh!

austincondiff avatar Sep 03 '24 03:09 austincondiff