CodeEditApp
Theme token formatting
Description
Formats tokens in themes to be bold or italic.
Related Issues
- #1717
Checklist
- [x] Put UI in place to configure theme tokens to be bold and or or italic from within theme details in settings
- [ ] Modify theme with these controls
- [ ] Ensure that these new formatting properties work with the source editor to bold or italicize each token if configured to do so
- [x] I read and understood the contributing guide as well as the code of conduct
- [x] The issues this PR addresses are related to each other
- [x] My changes generate no new warnings
- [x] My code builds and runs on my machine
- [x] My changes are all related to the related issue above
- [x] I documented my code
Screenshots
https://github.com/CodeEditApp/CodeEdit/assets/806104/f4129950-5771-455a-8781-c0f29665fd72
Before
https://github.com/CodeEditApp/CodeEdit/assets/806104/804cc5dc-529d-4a90-948c-07425274186f
After
https://github.com/CodeEditApp/CodeEdit/assets/806104/0405df94-81c0-4746-bfae-e6b3962ef200
Will this do essentially what https://github.com/CodeEditApp/CodeEditSourceEditor/pull/245 was trying to? If yes, I'll close my PR then 😅
@danielzsh Not really but we will probably need to adjust font weights in CESE in order for this to work, so we can address it all then. We really appreciate the effort, but go ahead and close it for now.
I did also notice there's some serious delay when updating the theme. I tracked this back to the fact that the themes are being saved every time a color is updated. We should throttle the saving action in the future, I'll make an issue for it.
Updated so the theme is updated in real time as it's edited (if it's the currently selected one) and the selected theme appearance defaults to the app's current color when opening the themes tab (eg if on light mode it shows the light mode ones first).
https://github.com/CodeEditApp/CodeEdit/assets/35942988/22cb9aea-a642-4433-ba26-6f4d42f6548b