CodeEdit
CodeEdit copied to clipboard
CodeEditApp
feat: exclude files and folders from project find and open quickly
Description
Introduces a Search section for Application Settings where the user is able to
add Glob Patterns for files that should be ignored in:
- Project Find (Indexing)
- Open Quickly
Related Issues
- #1463
Checklist
- [ ] I read and understood the contributing guide as well as the code of conduct
- [ ] The issues this PR addresses are related to each other
- [ ] My changes generate no new warnings
- [ ] My code builds and runs on my machine
- [ ] My changes are all related to the related issue above
- [ ] I documented my code
Screenshots
@CodeEditApp/maintainers I'm still playing with View Model and persisting these settings so I have the following UI which I'm not sure its pretty user friendly.
Based on the issue screenshot:
I gave a shot to VSCode appraoach and looks quick and easy to use:
https://github.com/CodeEditApp/CodeEdit/assets/34756077/fecff7f2-7c61-4573-95ab-ecc71cf02b2a
Any suggestions?
A pop-up might by a bit much. I think a table approach might be better? With editable rows
A pop-up might by a bit much. I think a table approach might be better? With editable rows
Totally! Thats tho current approach now! Thanks for the feedback!
Hey @EstebanBorai, how's it going on your end? Is the UI all set? If so, I can lend a hand in integrating it with the indexer. By the way, I've got #1465 on my plate, so feel free to merge the UI, and I'll roll out another PR incorporating your improvements for the actual indexing.
Hey @EstebanBorai, how's it going on your end? Is the UI all set? If so, I can lend a hand in integrating it with the indexer. By the way, I've got #1465 on my plate, so feel free to merge the UI, and I'll roll out another PR incorporating your improvements for the actual indexing.
Hey @activcoding! Yes please take a look, basically this implement the CRUD logic for Globs, its already loading from the settings file. Whats missing is the GlobPattern validation and actually make use of the GlobPatterns to ignore them
@EstebanBorai thanks, I had a chat with Austin yesterday, and he's all good with merging this PR as long as the CRUD logic is solid in settings. Your changes will come into play in a future PR. I'll work on it as soon as I'm done with mine.
Brilliant! Thanks for your great work.
Thanxs for you and @austincondiff for all the support guys!