CodeEdit
CodeEdit copied to clipboard
CodeEditApp
🐞 File opened via "Open In Tab" should be selected in Project Navigator
Description
If a file is opened through "Open In Tab", the file is not selected in Project Navigator and it still highlights the previous file (if there is a file opened by manual click) even though the new tab opens file.
To Reproduce
- Open the app
- Select a file in Project Navigator by clicking on it (you can skip it)
- Then open file using "Open In Tab" menu
Expected Behavior
The expected behavior should be to highlight the file opened via "Open In Tab" in Project Navigation.
Version Information
CodeEdit: 0.0.3-alpha.32 macOS: 13.3.1 Xcode: Version 14.3 (14E222b)
Additional Context
No response
Screenshots
https://github.com/CodeEditApp/CodeEdit/assets/67727096/c677b4bc-2c4b-430b-8ed8-e26da12fb3c4
After digging out the bug, I found that the Project Navigator highlights the file opened via "Open In Tab" as soon as the window is no longer active.
https://github.com/CodeEditApp/CodeEdit/assets/67727096/162bf97f-5657-4417-bb91-0ff21f0cfae9
@dscyrescotti good find! Thanks for bringing that to our attention!
@Wouter01 i wonder if it is related to this. I will check if this still happens in that branch.
@dscyrescotti good find! Thanks for bringing that to our attention!
@Wouter01 i wonder if it is related to this. I will check if this still happens in that branch.
I think it's somewhere inside the outlineview where it doesn't get some kind of event, but I haven't had a look at it
@Wouter01 yes it's indeed with the outlineview which doesn't update properly when tab is changed. So, it causes state inconsistency between the outlineview and active tab group. After a long investigation, I figured out to fix it by explicitly adding a listener to active tab group for the outlineview.
