CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🐞 Compile errors by SwiftLintPlugin

Open LostInCompilation opened this issue 2 years ago • 1 comments

Description

When trying to compile the current sources with XCode 14.3 on macOS 13.3.1(a) I get the following compilation error:

.../CodeEditLanguages/Tests/CodeEditLanguagesTests/CodeEditLanguagesTests.swift:12:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/CodeEditTextViewTests.swift:4:1 Usage of // swiftlint:disable all is prohibited
.../CodeEditTextView/Tests/CodeEditTextViewTests/STTextViewControllerTests.swift:7:1 Usage of // swiftlint:disable all is prohibited

The issues are raised by the packages CodeEditLanguages and CodeEditTextView. The cause is the latest update of SwiftLintPlugin from v0.2.2 to v0.2.3. This update updated SwiftLint from v0.50 to v0.51 which introduced stricter rules on blanket disable commands.

Disabling all SwiftLint checks is no longer supported. Only the necessary lint issues should be disabled.

To Reproduce

  1. Download a fresh clone of the repo
  2. Open the project in XCode and build it

Expected Behavior

No compiler/lint errors

Version Information

CodeEdit: Current repo state macOS: 13.3.1(a) Xcode: 14.3

Additional Context

No response

Screenshots

Screenshot 2023-05-14 at 18 15 23 Screenshot 2023-05-14 at 18 16 11

LostInCompilation avatar May 14 '23 16:05 LostInCompilation

For CodeEditLanguages I cannot find // swiftlint:disable all in the file anymore: https://github.com/CodeEditApp/CodeEditLanguages/blob/9e7b7c479fdb405910161e5002e137a1a88362a1/Tests/CodeEditLanguagesTests/CodeEditLanguagesTests.swift

Seems like an update to 0.1.14 should solve the issue for this package.

In CodeEditTextView the swiftlint lines are still present.

LostInCompilation avatar May 14 '23 16:05 LostInCompilation

I believe this should be closed now

FastestMolasses avatar Jul 24 '23 07:07 FastestMolasses