CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

🐞 Tabs animate incorrectly

Open austincondiff opened this issue 2 years ago • 7 comments

Description

Currently the tab and tab content animates in the wrong way.

What currently happens

When new file is opened, the new tab itself fades in while sliding in a few pixels from the left (this is expected)

When tab is closed, the tab fades out in place and the tab content fades out (both are not expected)

What should happen

The only animation that should take place is when a new tab is opened, the tab itself fades in while sliding a little to the right as it does now. All animations on tab closed should be removed.

Screenshots

https://user-images.githubusercontent.com/806104/220394988-d3d6e736-14b5-49f6-902b-7cb34e030900.mp4

austincondiff avatar Feb 21 '23 15:02 austincondiff

Can this be closed? Is this addressed by #1081 ?

matthijseikelenboom avatar Mar 03 '23 20:03 matthijseikelenboom

I just tested again and noticed there is one thing that is still incorrect. When closing a tab, the background of the new active tab fades in. We need to fix this before we can close this.

https://user-images.githubusercontent.com/806104/222829987-ef23bc31-3d5e-40dc-999f-6e44bee6e2ed.mp4

Notice the background of the newly active tab fading in.

austincondiff avatar Mar 03 '23 21:03 austincondiff

@maxkel would you be able to take a look at this?

austincondiff avatar Mar 04 '23 16:03 austincondiff

Yes, I will look into this. I have just one more question. If you close a tab with other tabs to the right. The behavior that the tabs to the right adjust their position with an animation like shown in the video below is intended, right?

https://user-images.githubusercontent.com/46418077/222920063-3cf69980-7d6c-4140-b807-9c9f1eeabc61.mov

maxkel avatar Mar 04 '23 17:03 maxkel

@maxkel Correct, we want to keep that animation of the tabs to the right animating their position, but we don't want the closed tab to fade out and we don't want the background of the newly selected tab to fade in.

austincondiff avatar Mar 04 '23 17:03 austincondiff

I recorded the animation and slowly scrubbed through it so you can see it a little better...

https://user-images.githubusercontent.com/806104/222921081-f84d3765-fa6b-472d-bbdd-8c98be3cc65a.mov

austincondiff avatar Mar 04 '23 17:03 austincondiff

Ok

maxkel avatar Mar 04 '23 17:03 maxkel