CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

✨ Keybindings Settings Pane

Open austincondiff opened this issue 2 years ago • 10 comments

Is your feature request related to a problem? Please describe.

We need to provide users with the ability to set and manage keybindings used in CodeEdit.

Describe the solution you'd like

Users need to be able to change keyboard shortcuts used to call commands within CodeEdit. We will eventually allow users to save and apply keybinding sets.

Additional context

Xcode's Keybinding Settings Pane

image

VS Code

image

macOS Keyboard Shortcuts

image

Proposed Design

image

image

image

austincondiff avatar Feb 16 '23 17:02 austincondiff

i'm taking this on before i start the move to ventura preferences, how should this look in the current/legacy preferences? I think a combination of the list like of VSCode and the filter at the top of xcode would be best for an initial implementation

luah5 avatar Mar 25 '23 07:03 luah5

@luah5 I don't recommend this since we will be rewriting some preferences/settings views. Wait until after moving over to Settings.

austincondiff avatar Mar 25 '23 08:03 austincondiff

ok, @austincondiff. on hold

luah5 avatar Mar 25 '23 08:03 luah5

I want to work on this feature. Is it the right time to work on it?

Omarbasaleh avatar May 13 '23 13:05 Omarbasaleh

@Omarbasaleh, It's ready since #1215 has been merged, I've already started tho, would you like to collaborate as this still needs more discussion to be compatible with extensions?

luah5 avatar May 13 '23 15:05 luah5

Sure

On Sat, 13 May 2023 at 6:24 PM luah5 @.***> wrote:

@Omarbasaleh https://github.com/Omarbasaleh, It's ready since #1215 https://github.com/CodeEditApp/CodeEdit/pull/1215 has been merged, I've already started tho, would you like to collaborate as this still needs more discussion to be compatible with extensions?

— Reply to this email directly, view it on GitHub https://github.com/CodeEditApp/CodeEdit/issues/1056#issuecomment-1546689248, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHB75JJYXR7BQXJKZDSUXN3XF6RT3ANCNFSM6AAAAAAU6PT3EQ . You are receiving this because you were mentioned.Message ID: @.***>

Omarbasaleh avatar May 13 '23 15:05 Omarbasaleh

@luah5 This is actually not ready quite yet. The settings view does no good if the underlying functionality is not built. Please refer to this thread on Discord. We need better support for commands in CodeEditKit first (see #222 and #224).

austincondiff avatar May 13 '23 16:05 austincondiff

OK. Will check that thread

On Sat, 13 May 2023 at 7:02 PM Austin Condiff @.***> wrote:

@luah5 https://github.com/luah5 This is not ready yet. The settings view does no good if the underlying functionality is not built. Please refer to this thread https://discord.com/channels/951544472238444645/954084547694325861/1105938921549996122 on Discord. We need better support for commands in CodeEditKit first.

— Reply to this email directly, view it on GitHub https://github.com/CodeEditApp/CodeEdit/issues/1056#issuecomment-1546699454, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHB75JJW46A35R46HE3M6Z3XF6V75ANCNFSM6AAAAAAU6PT3EQ . You are receiving this because you were mentioned.Message ID: @.***>

Omarbasaleh avatar May 13 '23 18:05 Omarbasaleh