CodeEdit icon indicating copy to clipboard operation
CodeEdit copied to clipboard

✨ Setting to toggle line number visibility

Open ben-p-commits opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe.

This is the sibling issue to CETV's issue https://github.com/CodeEditApp/CodeEditTextView/issues/115 (Option To Hide Line Numbers). Line numbers should be an option that can be toggled, just like in Xcode.

Describe the solution you'd like

Line numbers should have a "Show:" boolean preference just like they do in Xcode.

There should be an accompanying palette command as well.

Describe alternatives you've considered

N/A- maintainers have voiced support for this approach in discussion under... https://github.com/CodeEditApp/CodeEditTextView/issues/115

Additional context

from Xcode

image

ben-p-commits avatar Jan 23 '23 21:01 ben-p-commits

Adding this for posterity- I have implemented this change, and the supporting changes in CodeEditTextView are handled in https://github.com/CodeEditApp/CodeEditTextView/pull/124.

PR for CodeEdit is pending the next update to CETV.

ben-p-commits avatar Jan 23 '23 21:01 ben-p-commits

Update: PR #124 was closed and we are waiting on #127 until we can proceed.

austincondiff avatar Feb 16 '23 23:02 austincondiff