pinia-orm icon indicating copy to clipboard operation
pinia-orm copied to clipboard

Inconsistency in has_many_save_uid test ?

Open oaubert opened this issue 1 year ago • 1 comments

In https://github.com/CodeDredd/pinia-orm/blob/5813664d03e46a86a9ffb0e13dc4d51c8e211fb4/packages/pinia-orm/tests/feature/relations/has_many_save_uid.spec.ts#L17 the userId key is declared as a number, while the declaration in the User class states that it is a uid (string): @Uid() id!: string. It looks like an inconsistency.

oaubert avatar Jun 17 '24 14:06 oaubert

You are right i defined the wrong type for userId. Not all tests are perfectly written 😉

CodeDredd avatar Jun 17 '24 19:06 CodeDredd