BungeeTabListPlus
BungeeTabListPlus copied to clipboard
CodeCrafter47
Add Velocity Support
A few points I want to give my personal input towards.
One main thing that should be done, but that I didn't want to mention on every single file, is to update the copyright header for every added and changed file to have 2025 as the year, since this was the year those files where added/changed and where the copyright becomes effective.
Who should I copyright on this because it certainly wasn't Florian that ported it. Should I copyright with my own name or is there a project setup so that BungeeTabListPlus can be copywritten in itself?
Who should I copyright on this because it certainly wasn't Florian that ported it. Should I copyright with my own name or is there a project setup so that BungeeTabListPlus can be copywritten in itself?
It should work having both. Like
Copyright (c) (your name) Copyright (c) (btlp dev)
Saw this within other projects.
Personally, I find the copyright notices a bit annoying to keep up-to-date. If you want, then you can update them, but I would also be fine merging this as is. Adding your own name, as Andre601 suggests, is fine.
I was told copyright really is only necessary to update for files that get updated.
At least the newly sdded files should use 2025, as they didn't exis before, no?
Copyrights have been updated, the metrics have changed to the new ID for velocity, and I adjusted the Team packet to use an enumeration for modes as well as cleaned up some of the map initializers.
Is this good to be merged from your side?
As long as there are nothing else needing changed and we are good on all the questions, then this can be merged.