BungeeTabListPlus icon indicating copy to clipboard operation
BungeeTabListPlus copied to clipboard

BungeeTablistPlus breaks on latest waterfall (Build 508/509)

Open Erlpil opened this issue 2 years ago • 18 comments

Hello,

BungeeTablistPlus breaks on latest waterfall (Build 508/509)

Here is the stacktrace: https://pastebin.com/raw/Vzz74iQi

Worked fine on Waterfall build 507, but then they added 1.19.3 support today, it broken on upgrade.

Please let me know if you need more info.

Erlpil avatar Dec 07 '22 21:12 Erlpil

Just to mention that same happens to the latest Bungeecord (1.19.3). It seems tablist function is significantly different on 1.19.3 compared to 1.19.2. Here's the bungeecord log: https://pastebin.com/9E2WU1H8

Please also find the change log in the bungeecord repository as it may help developers to catch up with the changes: https://github.com/SpigotMC/BungeeCord/commit/5467e3a8424fdc4b72a26fc35d9a0432333fa4b2

Looking forward to a solution :)

fanmuchen avatar Dec 08 '22 05:12 fanmuchen

Same problem here. @CodeCrafter47

andrewkm avatar Dec 08 '22 17:12 andrewkm

Same problem here. @CodeCrafter47

No need to tag. He can and will see it.

Andre601 avatar Dec 08 '22 17:12 Andre601

Might just need a rebuild as Bungee changed int to Integer there.

Phoenix616 avatar Dec 09 '22 13:12 Phoenix616

The newest dev builds seem to work on the newest Bungeecord with 1.19.3 support. Try checking that out as a temporary alternative to the stable builds.

https://ci.codecrafter47.de/job/BungeeTabListPlus/

Correction: it doesn't work according to the post under me. I'm not sure why I got mine working though. Oh well.

NathanAdhitya avatar Dec 11 '22 04:12 NathanAdhitya

^It is confirmed that this is not the case. BungeeTabListPlus is as of this moment still broken and will not work with Bungeecord/Waterfall that is built to allow 1.19.3 compatibility.

Erlpil avatar Dec 12 '22 19:12 Erlpil

^It is confirmed that this is not the case. BungeeTabListPlus is as of this moment still broken and will not work with Bungeecord/Waterfall that is built to allow 1.19.3 compatibility.

You should really provide information about what issues you have when you claim that... otherwise it can't be fixed.

Phoenix616 avatar Dec 12 '22 19:12 Phoenix616

^It is confirmed that this is not the case. BungeeTabListPlus is as of this moment still broken and will not work with Bungeecord/Waterfall that is built to allow 1.19.3 compatibility.

You should really provide information about what issues you have when you claim that... otherwise it can't be fixed.

This has been discussed in length on their Discord. The errors originally posted are still valid. More and more people are also reporting this issue there, even with the latest dev build.

Erlpil avatar Dec 12 '22 19:12 Erlpil

Well not everyone has access to some random Discord or can find a certain conversation days after. Providing all available information when posting publicly can be extremely helpful especially if other people could fix the issue too that weren't in that private conversation you mentioned.

Phoenix616 avatar Dec 12 '22 19:12 Phoenix616

Well not everyone has access to some random Discord or can find a certain conversation days after. Providing all available information when posting publicly can be extremely helpful especially if other people could fix the issue too that weren't in that private conversation you mentioned.

While on one hand I like the help you give, telling others what they should do on a project that isn't their own is not something you should do here. But that's beyond this issue's main topic, so let's stay on it.

The issue is known and CodeCrafter will work on it once he can find time (PRs are welcome tho if you guys can fix it yourself).

Andre601 avatar Dec 12 '22 19:12 Andre601

The issue is known and CodeCrafter will work on it once he can find time (PRs are welcome tho if you guys can fix it yourself).

Well I can't PR if I don't know what the issue is. I previously compiled against the latest bungee myself (which essentially is what the latest build should do too?) and it works just fine with 1.19.3 for me so there must be a different one hence why I felt that more information was needed.

I'm sorry I didn't formulate that in a way that made my goal to get that information and why clear.

Phoenix616 avatar Dec 12 '22 20:12 Phoenix616

CodeCrafter pushed an update. Testing it is appreciated: https://ci.codecrafter47.de/job/BungeeTabListPlus/

Notes from the Discord:

What is not tested:

  • Using the latest BungeeCord and older spigot or client versions. I expect this works fine.
  • Using an older BungeeCord without 1.19.3 support. I expect that this will not work. If that is the case, then future versions of the plugin might print a warning and refuse to start.
  • Not using ip-forwarding (this is probably fine)
  • Using ViaVersion on BungeeCord with a 1.19.3 spigot and 1.7.10 client. I have no idea if this will work.

What won't work:

  • Using Geyser. I plan to look into that next weekend.

Andre601 avatar Dec 13 '22 12:12 Andre601

The version on the link seams to fix the issue, I also tested 1.18.2 and that works too.

broken1arrow avatar Dec 28 '22 15:12 broken1arrow

Same problem here, start at line 103. See full log at pastebin.com/BXg9pmMm

[10:07:14] [Netty Worker IO Thread #3/ERROR] [BungeeTabListPlus]: An internal error occurred! Please send the following StackTrace to the developer in order to help resolving the problem
java.lang.NoSuchMethodError: 'int net.md_5.bungee.protocol.packet.PlayerListItem$Item.getGamemode()'
	at codecrafter47.bungeetablistplus.handler.GetGamemodeLogic.onPlayerListPacket(GetGamemodeLogic.java:40) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.AbstractPacketHandler.onPlayerListPacket(AbstractPacketHandler.java:40) ~[?:?]
	at codecrafter47.bungeetablistplus.handler.RewriteLogic.onPlayerListPacket(RewriteLogic.java:101) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.PacketListener.decode(PacketListener.java:62) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.PacketListener.decode(PacketListener.java:32) ~[?:?]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:333) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:454) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:499) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:397) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

CodeZhangBorui avatar Jan 23 '23 02:01 CodeZhangBorui

Same problem here, start at line 103. See full log at pastebin.com/BXg9pmMm

[10:07:14] [Netty Worker IO Thread #3/ERROR] [BungeeTabListPlus]: An internal error occurred! Please send the following StackTrace to the developer in order to help resolving the problem
java.lang.NoSuchMethodError: 'int net.md_5.bungee.protocol.packet.PlayerListItem$Item.getGamemode()'
	at codecrafter47.bungeetablistplus.handler.GetGamemodeLogic.onPlayerListPacket(GetGamemodeLogic.java:40) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.AbstractPacketHandler.onPlayerListPacket(AbstractPacketHandler.java:40) ~[?:?]
	at codecrafter47.bungeetablistplus.handler.RewriteLogic.onPlayerListPacket(RewriteLogic.java:101) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.PacketListener.decode(PacketListener.java:62) ~[?:?]
	at codecrafter47.bungeetablistplus.protocol.PacketListener.decode(PacketListener.java:32) ~[?:?]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:88) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:286) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:333) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:454) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:800) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:499) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:397) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) ~[waterfall-1.19-510.jar:git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

What version do you use?

broken1arrow avatar Jan 23 '23 05:01 broken1arrow

Same problem here, start at line 103. See full log at pastebin.com/BXg9pmMm

What version do you use?

Waterfall version git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510 by md_5

CodeZhangBorui avatar Jan 23 '23 05:01 CodeZhangBorui

Same problem here, start at line 103. See full log at pastebin.com/BXg9pmMm

What version do you use?

Waterfall version git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510 by md_5

I mean the plugin. Because last dev solve this issue.

broken1arrow avatar Jan 23 '23 05:01 broken1arrow

Same problem here, start at line 103. See full log at pastebin.com/BXg9pmMm

What version do you use?

Waterfall version git:Waterfall-Bootstrap:1.19-R0.1-SNAPSHOT:13085b9:510 by md_5

I mean the plugin. Because last dev solve this issue.

I'm sorry that I used the old version (3.5.2) to test, I've downloaded the lastest dev build and solved this problem :)

CodeZhangBorui avatar Jan 23 '23 05:01 CodeZhangBorui