foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Make RlpStream::append() return an error when more than reserved number of items are appended

Open sgkim126 opened this issue 6 years ago • 2 comments

https://github.com/CodeChain-io/codechain/blob/d91b73a0fe81a8a1431e704d9ef73276ef43ef59/util/rlp/src/stream.rs#L397-L409 this tests the behavior. Make the above test pass.

sgkim126 avatar Jul 16 '18 06:07 sgkim126

d91b73a0fe81a8a1431e704d9ef73276ef43ef59 added a test case.

kseo avatar Jul 17 '18 06:07 kseo

I read the code, and this is not the only problem for append(). There are bunches of panic!()s and those should be replaced with the code that throws an errors as this issue points.

hyunsikjeong avatar Nov 27 '18 09:11 hyunsikjeong