foundry icon indicating copy to clipboard operation
foundry copied to clipboard

Organize validator set

Open junha1 opened this issue 4 years ago • 0 comments

Types

Eventually, we will have only 3 types for validators.

  1. ctypes::Validator - It has two fields: public_key and weight.
  2. ctypes::ValidatorSet - It is a newtype of Vec<Validator>, but it save it sorted, and provides methods to save to/load from state. Also, its hash will be directly written in block header.
  3. foundry_graphql_engine::Validator GraphQL resolver for validator.

All other types will be completely removed. (NextValidatorSet, CurrentValidatorSet, SimpleValidator, WeightOrderedValidators, ...)

Naming

Validators -> Validator set delegation/deposit/ ... -> weight

Next / Current

Both will be saved, but share same type ValidatorSet.

Coordinator-Module interface

Will be asked to return only Vec<Validator> as the validator set.

Test

We have to add various e2e tests that involve multiple nodes + varying validator set.

junha1 avatar Oct 20 '20 07:10 junha1