codechain Check --notify-work values are URLs on start

Check --notify-work values are URLs on start

Open joojis opened this issue 6 years ago • 6 comments

Currently, the below command works without any error or warning.

./codechain --notify-work 127.0.0.1:3333 ...

But actually, it should be like:

./codechain --notify-work http://127.0.0.1:3333 ...

Sep 14 '18 07:09 joojis

Should this work in the http protocol? Or is it a matter of not specifying the protocol?

Oct 26 '18 02:10 hea9549

@hea9549 Just http is ok to me. :)

Oct 26 '18 04:10 joojis

@joojis What's about stratum?

Oct 26 '18 04:10 sgkim126

@sgkim126 Is it different? I'm not sure. It seems that string is only used for HTTP request.

Oct 26 '18 06:10 joojis

@joojis As far as I remember, stratum uses TCP socket directly. But I'm not sure stratum support for notify-work is done.

@kseo Do you know the current status of it?

Oct 26 '18 07:10 sgkim126

@sgkim126 You are right, stratum is used TCP socket for notify-work and submitting a solution. so '--notify-work' arg isn't related to stratum.

Dec 19 '18 00:12 kakao-jun-e