codechain-sdk-js

codechain-sdk-js copied to clipboard

`#https://github.com/CodeChain-io/codechain-sdk-js/blob/914417897115bb971e5c58bf3ee6295f804e5bd6/src/core/transaction/MintAsset.ts#L55` @redongjun @qdigital

Qdigital

The type of params in the createStoreTransaction in the document is `object | object`.  But the code has much information in the comments and the type is not object:...

majecty

Assuming `tc` as default `networkID` is not problem. But in the first example code of [codechain sdk document](https://api.codechain.io/2.0.1/index.html), `networkID` is not specified while constructing SDK object. This might cause confusion...

cubistplay

Remove the unused opcode

2

`BLKNUM` (0xa0) should be removed. Related issue: https://github.com/CodeChain-io/codechain/pull/1836

joojis

We need a high-level script language that is similar to [Ivy](https://docs.ivy-lang.org/bitcoin/language/) for ease of writing scripts.

kseo

Latest LTS is nodejs 10. It supports up to ES2017 and ES2017 supports async/await natively. Then we can leverage nodejs 12's `async-stack-traces` to debug our code.

foriequal0

joojis

joojis

For consistency with other core classes, Deprecate - fromJSONToTransaction() - fromJSONToSignedTransaction() and add - Transaction.fromJSON() - SignedTransaction.fromJSON()

joojis

It's possible that the transaction already has fee and seq.

joojis