Mikel Blanchard
Mikel Blanchard
@almostchristian In your code above you are clearing the logger providers which removes Serilog's ILogger integration. Try removing that line: ```csharp builder.WebHost.ConfigureLogging((ctx, builder) => { // builder.ClearProviders(); { options.AddConsoleExporter(); });...
@liutiexing I don't think we could change this without breaking anyone. And I'm not sure we want to. The current setup is friendly to AspNetCore with a lot of middleware...
@ajnavsun1806 > will the Baggage instance is shared across all the requests Not exactly! It wouldn't be very useful at all if it worked like that 😄 `Baggage.Current` is (by...
@BrennanConroy Thanks for the link! I don't think `{OriginalFormat}` is really needed on scopes. `HttpRequestLog` & `HttpResponseLog` probably need it, but not sure what the template would be exactly. In...
@VladyslavLishchyna I just spent some time trying to reproduce this and so far haven't been able to. Can you provide me with a small app that reproduces the problem? If...
RE: https://github.com/open-telemetry/opentelemetry-dotnet/pull/5208#issuecomment-1892695769 @alanwest's proposed API is this: ```csharp void Main() { using (var scope1 = ContextBuilder.NewContext().WithBaggage("key1", "key1").StartScope()) { // Baggage.Current contains key1/value1 using (var scope2 = ContextBuilder.NewContext().WithBaggage({"key2", "value2"}).StartScope()) { //...
@reyang Those APIs are still there on `readonly struct Baggage`. The things being obsoleted on this PR are the static APIs which mutate the ambient context. Here are the untouched...
@reyang > I still don't understand, for example, how to use this in the following situation: > > https://github.com/open-telemetry/opentelemetry-dotnet/blob/dfd27c50408e770963f9d60880c1da04810c409d/src/OpenTelemetry.Instrumentation.GrpcNetClient/Implementation/GrpcClientDiagnosticListener.cs#L62 You wouldn't use the `Attach` API here. If you are writing...
I'm fine with the API addition. Feel free to open a PR @Kahbazi and I will review it. > Also to support this the OpenTelemetry.Instrumentation.StackExchangeRedis project need to add .NET...
> @lachmatt - please add the changelog as well. Yes I think we should mention this in CHANGELOG and note that is it potentially a breaking change.