carnac icon indicating copy to clipboard operation
carnac copied to clipboard

Support showing ctrl, alt, win keys pressed down without any other key

Open bfritscher opened this issue 7 years ago • 7 comments

  • Removed filtering of modifierkey to allow to handle them in ToInputs.
  • Filtered triggering of modifier display for modifierkeys themselves in ToInputs.
  • Exposed IsModifierKeyPress as static to be used in KeyPress and Messages.
  • KeyPress.HasModifierPress returns false if key is a modifierkey itself (allow the merging in Message).
  • Message disable repeat counting incrementing for modifierkeys themself, but still handling their repeat, in order for them to keep showing while keydown.

This should partially solve issue #154 Note sure about the sticky key part on mac.

bfritscher avatar Jul 14 '17 22:07 bfritscher

after integrating it with my other changes i found there are bugs, and found another solution, but it now seems to fail the tests :-(

But a side effect is that it now support issue #76

bfritscher avatar Jul 17 '17 10:07 bfritscher

Hey @bfritscher,

I haven't forgotten about your PRs, I've just been busy with some other things lately. I should have some time over the next week or so to sit down and review your PRs.

My apologies for the delay in getting to them!

Thanks, henrik

hnrkndrssn avatar Aug 08 '17 21:08 hnrkndrssn

@alfhenrik No problems :-) And I understand that they are a bit more complex. They also might need some test cases, in order to cover edge cases. Happy to do some changes after your insights. Best regards, Boris

bfritscher avatar Aug 09 '17 05:08 bfritscher

To solve this issue would be so helpful, to show CTRL SHIFT stand alone. Any progress maybe?

king3dward avatar Aug 01 '18 21:08 king3dward

I was looking to get a counter on the modifier keys specifically, but there seems no option to do so...

clragon avatar Oct 12 '19 15:10 clragon

  • Removed filtering of modifierkey to allow to handle them in ToInputs.
  • Filtered triggering of modifier display for modifierkeys themselves in ToInputs.
  • Exposed IsModifierKeyPress as static to be used in KeyPress and Messages.
  • KeyPress.HasModifierPress returns false if key is a modifierkey itself (allow the merging in Message).
  • Message disable repeat counting incrementing for modifierkeys themself, but still handling their repeat, in order for them to keep showing while keydown.

This should partially solve issue #154 Note sure about the sticky key part on mac.

Hi, @bfritscher I really appreciate your work to add the mouse highlight, but the https://github.com/bfritscher/carnac/tree/v3-beta seem have a bug, like #173 descripe, when hold two keys and left click, but it dosen't show any key just the mouse icon.

Benbinbin avatar Feb 15 '20 03:02 Benbinbin

Any possibility of getting this merged?

crutchcorn avatar Aug 19 '21 22:08 crutchcorn