contratospr-api icon indicating copy to clipboard operation
contratospr-api copied to clipboard

"project_setup" incompatible with python_version > 3.7

Open jycordero opened this issue 3 years ago • 3 comments

Describe the bug

The logic in the project_setup makes it so that you are required to have python 3.7 installed, even though the language suggest that you could run it with higher versions. This is not a big problem, either make it clear that python 3.7 is the only supported version or change the logic so that is includes python_version > 3.7.

If the solution is to make clear that only python 3.7 is supported then people could be warned not to change the requirements on the Pipfile fo force to work with python 3.8.

To Reproduce

Steps to reproduce the behavior: Un-install python3.7 install python3.8 setup stops and a message shows up

"Please install Python version 3.7.2 or greater"

Expected behavior work with any version of python that is higher than 3.7

jycordero avatar Mar 09 '21 18:03 jycordero

Para nosotros toda contribución es importante. ¡Gracias por darnos de su tiempo y hacer tu primera contribución! Estaremos dandole un vistazo pronto.' first issue

github-actions[bot] avatar Mar 09 '21 18:03 github-actions[bot]

Thanks for reporting this! I'm up for improving for sure. There's no real reason to pin specifically to 3.7, but I'd like to enforce >=3.7 somewhere(maybe version check in manage.py for example)

Pipenv makes this hard, so we could remove the python_version from there. We'd also have to tweak that project-setup script to account for that.

Interested in working on it?

jpadilla avatar Mar 10 '21 13:03 jpadilla

This Issue is being marked as Stale because it has 30 days without any interaction. CC: @froi @jpadilla

github-actions[bot] avatar Apr 11 '21 00:04 github-actions[bot]