vz icon indicating copy to clipboard operation
vz copied to clipboard

Help: Tests Not Executing on macOS 13 (amd64)

Open Code-Hex opened this issue 2 years ago • 4 comments

Describe the bug

make test on macOS 13 (amd64) is not executing tests.

See: https://github.com/Code-Hex/vz/actions/runs/6452512346/job/17514882857?pr=134

To Reproduce

make test

Expected behavior

Pass tests

Screenshots If applicable, add screenshots to help explain your problem.

Environment that you use to compile (please complete the following information):

https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md

  • Xcode version: https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md#xcode
  • macOS Version: 13.6 22G120
  • mac architecture: amd64
  • Go Version: 1.20, 1.21

Code-Hex avatar Oct 09 '23 05:10 Code-Hex

@cfergeau @balajiv113 Could you check this if possible? 🙏

Code-Hex avatar Oct 09 '23 05:10 Code-Hex

@Code-Hex With lima we noticed that the macOS 13 runner is unstable and tend to fail when resource are highly used. We found it to be mostly green (still fails at times) when used 1core and 1gb memort

Here since we are using go test, maybe different tests are running in parallel. We can try disabling by using go test -p 1 ./...

balajiv113 avatar Oct 09 '23 05:10 balajiv113

My amd64 macbook is still using macOS 12. The tests are passing locally on amd64+macOS 12, but the CI run is green in this scenario.

Seeing https://github.com/Code-Hex/vz/actions/runs/6452512346?pr=134 :

The job running on runner GitHub Actions 2 has exceeded the maximum execution time of 6 minutes.

it looks like the test does not have a lot of time allowed before being killed?

cfergeau avatar Oct 09 '23 12:10 cfergeau

@balajiv113 Thank you. It seems like this issue is indeed occurring, and it's only affecting macOS 13. It's been quite challenging as it fails most of the time. It's a complex problem.

In CI, it seems like there are frequent failures with read/write operations on the Directory Share.

the macOS 13 runner is unstable and tend to fail when resource are highly used.

@cfergeau I fixed timeout.

Code-Hex avatar Oct 10 '23 03:10 Code-Hex