cocoapods-downloader icon indicating copy to clipboard operation
cocoapods-downloader copied to clipboard

Fix bug of Git shallow cloning is not used when branch is set

Open dimohamdy opened this issue 3 years ago • 4 comments

Fix https://github.com/CocoaPods/cocoapods-downloader/issues/106

dimohamdy avatar Aug 10 '21 20:08 dimohamdy

@dnkoutso I cleaned the branch and update the changelog

dimohamdy avatar Aug 10 '21 20:08 dimohamdy

@dimohamdy Hi,I noticed the line of code you deleted:

# lib/cocoapods-downloader/git.rb
options.delete(:branch)

The relevant code comes from a PR #57 , which is used to deal with the cache problem of cocoapods(:git && :branch). If you delete this line of code, it may affect the pod (:git && :branch) cache detection of cocoapods. I don’t know if you have tested these scenarios.

xuzhongping avatar Jan 08 '22 13:01 xuzhongping

Any chance, this gets merged?

uliluckas avatar May 12 '22 10:05 uliluckas

This would be useful to have 🙏

ptrkstr avatar Aug 07 '23 10:08 ptrkstr