cocoapods-acknowledgements icon indicating copy to clipboard operation
cocoapods-acknowledgements copied to clipboard

Published 20 hours ago • verified publisher icon CocoaPods

Html rendering

Open lolgear opened this issue 7 years ago • 6 comments

Architecture changed.

  1. Base class Generator added.
  2. Module Auxiliaries added which contains file handling operations. Could be merged into base class Generator.
  3. HTMLGenerator added.
  4. Plist and HTML Writers added which handles output to appropriate file format.

lolgear avatar Feb 13 '18 18:02 lolgear

@segiddins updated. nokogiri dependency removed.

lolgear avatar Feb 13 '18 21:02 lolgear

Any chance of merging this branch ?

hamdshah avatar Feb 06 '19 14:02 hamdshah

I don't think it's done, see: https://github.com/CocoaPods/cocoapods-acknowledgements/pull/47/files#diff-86a5d812fd9ecac367ea96aaa1964994R4

orta avatar Feb 06 '19 15:02 orta

@orta It is an obsoleted class. ( or duplicate ). I use PlistGenerator instead. They are identical in terms of Model. You can check invocations of HTMLGenerator. Maybe anybody can figure out what we can do with it in future. For now it is empty and it copies whole body of PlistGenerator. ( yeah, copy-paste is evil ).

Update: HTMLWriter consumes PlistGenerator::SpecObject to generate correct output.

lolgear avatar Feb 06 '19 15:02 lolgear

Weird, build error.

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.3)
  Current Bundler version:
    bundler (2.0.1)

lolgear avatar Feb 10 '19 14:02 lolgear

@segiddins Could you post a review?

lolgear avatar Mar 17 '19 16:03 lolgear