CocoaPods icon indicating copy to clipboard operation
CocoaPods copied to clipboard

fix: ensure reinstall when other install touch sandbox but still not write to manifest.

Open SolaWing opened this issue 5 years ago • 4 comments

this patch by touch a mark file before install, and delete when save manifest, to ensure if install cancel, the touched source will be reinstall.

closes: #9128

SolaWing avatar Sep 19 '19 05:09 SolaWing

Why does this need to write to disk? Could the standbox store this information in a hash?

segiddins avatar Oct 26 '19 04:10 segiddins

write to disk is to ensure when cancel and reinstall, the touched pod can be detect. if only store in memory hash, this information is lost after cancel

SolaWing avatar Oct 26 '19 10:10 SolaWing

@SolaWing Hi,this looks great, but doesn't seem to take into account the 'external' pods, the current processing is for 'release' pods,consider fixing that part too?

xuzhongping avatar Jan 30 '22 04:01 xuzhongping

@xuzhongping good point, I add the external donwload check in analyzer

SolaWing avatar Jan 30 '22 07:01 SolaWing