NachoSpigot icon indicating copy to clipboard operation
NachoSpigot copied to clipboard

TPS drop

Open Fejm opened this issue 2 years ago • 13 comments

Observed Behavior

TPS drops even on empty server to ~19.25

[21:58:43 INFO]: TPS from last 1m, 5m, 15m: 19.75, 19.75, 19.91 No players, no plugins, clean test server, new world, no CPU usage at all (Ryzen 7 3800X), 4GB RAM allocated, JAVA 17

Expected Behavior

TPS = ~19.99

Steps To Reproduce

Just start server, without plugins..

Plugin List

none

Server Version

[21:52:58 INFO]: Checking version, please wait... [21:52:59 INFO]: This server is running NachoSpigot version git-NachoSpigot-74ed0ea (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT) You are running the latest version

Other

No response

Agreements

  • [X] You were able to find this issue on the latest version of NachoSpigot.
  • [X] You have confirmed that there aren’t any issues open regarding this bug.

Fejm avatar May 12 '22 20:05 Fejm

I believe the server tps is actually stable, the latest Paper uses BigDecimals to calculate tps which is more accurate than the current system. After updating Paper's tick loop improvement patch, the tps display will probably be more accurate.

windcolor-dev avatar May 14 '22 00:05 windcolor-dev

I tried to update this patch, no change at all in tps display. Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps.

To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

Fejm avatar May 14 '22 07:05 Fejm

I tried to update this patch, no change at all in tps display.

Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps.

To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

Are you testing this on Windows?

ytnoos avatar May 14 '22 08:05 ytnoos

I tried to update this patch, no change at all in tps display. Adding debug sysout in loop shows that server is ticking 51 - 52 ms, ofc server is trying to catch up at 49ms but it's not too much.. So actually tps display is correct - there is no 20 tps. To be honest, server is not lagging, you can modify max tps and server will tick higher without any problem. There is problem in Thread.sleep calc, server is waiting too long and its unable to catchup.

Are you testing this on Windows?

On Windows 11 and Debian 11. Same issue.

Fejm avatar May 14 '22 08:05 Fejm

hmm that's weird, on my fork I updated the patch and tps ranges from 19.99-20 whilst idling

windcolor-dev avatar May 14 '22 15:05 windcolor-dev

hmm that's weird, on my fork I updated the patch and tps ranges from 19.99-20 whilst idling

Can i look on your patch?

Fejm avatar May 14 '22 18:05 Fejm

Yeah, here are my changes: https://github.com/Wind-Development/WindSpigot/pull/21/files

windcolor-dev avatar May 14 '22 20:05 windcolor-dev

Well, this is exactly what I did myself. What CPU you are using? Intel?

Fejm avatar May 14 '22 21:05 Fejm

I've checked tps on servers running on the Intel i5-9300H and an arm cpu from oracle cloud. Servers' tps on the oracle cloud instance drops to 19.97 at times, but there are like 5 servers running on the same instance.

windcolor-dev avatar May 14 '22 22:05 windcolor-dev

timings?

HowardZHY avatar May 15 '22 18:05 HowardZHY

try to use Java 11 or 8

ghost avatar May 16 '22 21:05 ghost

try to use Java 11 or 8

Tested on 8, 11 and 17. Same results.

Fejm avatar May 18 '22 17:05 Fejm

send ur timings report

在 2022-05-19 01:05:46,"Mateusz Filipczak" @.***> 写道:

try to use Java 11 or 8

Tested on 8, 11 and 16. Same results.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

HowardZHY avatar May 18 '22 17:05 HowardZHY