DebugViewPP icon indicating copy to clipboard operation
DebugViewPP copied to clipboard

Remove color support from "Include" filter.

Open Ishmaeel opened this issue 3 years ago • 3 comments

I would very much like to use the "include" filter but the fact that it has precedence over dynamic process colors has been a deal breaker.

Now include filter does not apply text coloring either, very much like the exclude filter. Not a big functionality loss because it is still possible to recolor included lines by defining an additional highlight rule. Perhaps more work, but definitely more flexibility.

Accept PR if it makes sense. Reject if not compatible with project vision.

Ishmaeel avatar Jul 30 '21 19:07 Ishmaeel

thanks for the suggestion, I can see your point, you mean that if you use the include filter, it will apply its color to the included line, and overwrite the 'process color' ?

janwilmans avatar Jul 31 '21 11:07 janwilmans

Yes, process coloring stops working as soon as an include filter is added.

Ishmaeel avatar Jul 31 '21 12:07 Ishmaeel

Thanks for the suggestion, I will have another look at feature requests.

janwilmans avatar Jun 30 '22 08:06 janwilmans