xna-cncnet-client icon indicating copy to clipboard operation
xna-cncnet-client copied to clipboard

Add ability for host to change game name

Open 11EJDE11 opened this issue 10 months ago • 5 comments

Adds the ability for the host to change a game's lobby name from within the lobby itself. The host can type:

/gamename <newname>

The new name is validated, then broadcast to all online players, and all players in the channel.

I've moved the lobby name validation checks to the NameValidator.cs file.

11EJDE11 avatar Feb 11 '25 01:02 11EJDE11

Nightly build for this pull request:

github-actions[bot] avatar Feb 11 '25 01:02 github-actions[bot]

yeah, the CnCNet lobby is different from a game (game room)

SadPencil avatar Feb 12 '25 09:02 SadPencil

please double check the lobby stuffs in the git diff. I saw this word again in the XML comment.

SadPencil avatar Feb 12 '25 19:02 SadPencil

I just tested this locally, there is a problem:

As player 1 (Host)

  1. Create a game
  2. Change the game room name

As player 2

  1. Do not join the game, wait for the game room name to change
  2. Attempt to join the room. You will see an error saying "Incorrect password"

image

GrantBartlett avatar Feb 19 '25 14:02 GrantBartlett

I just tested this locally, there is a problem:

Fixed now.

11EJDE11 avatar Apr 06 '25 03:04 11EJDE11

Closing as I'll do a new PR with a GUI and more options.

image

11EJDE11 avatar Oct 28 '25 04:10 11EJDE11