Fix handling of messages containing ACTION
Currently any chat message containing "ACTION" will get handled incorrectly.
I assume this was a debugging thing from years ago and can be removed completely. Alternatively we could change it to StartsWith u0001 + "ACTION".
Can anyone reviewing this also check the two instances of ACTION here as I think they can be removed too? https://github.com/CnCNet/xna-cncnet-client/blob/f11f56f5a80f141faa998cf3566948afe5021d1c/DXMainClient/Online/Connection.cs#L696
Nightly build for this pull request:
- artifacts-YR.zip
- artifacts-Ares.zip
- artifacts-TS.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.
The client used to have notifications like <player> has hosted a new <game> game, like 11EJDE11 has hosted a new Tiberian Sun game. FunkyFr3sh's CnCNet client used to broadcast these with ACTIONs, so this was done to have better compatibility with his client.
I can't recall seeing these messages in years though, so FF possibly changed his logic at some point, meaning this can likely be removed now.
I can't recall seeing these messages in years though, so FF possibly changed his logic at some point, meaning this can likely be removed now.
I think someone should go on CnCNet TS/RA1/TD/D2k channels to verify that is indeed the case.
Any progress on this?