xna-cncnet-client icon indicating copy to clipboard operation
xna-cncnet-client copied to clipboard

Fixed .editorconfig and added validation to workflows

Open Belonit opened this issue 3 years ago • 8 comments

We use this workflow at Phobos and it works well

Belonit avatar Sep 14 '22 19:09 Belonit

FYI we are planning to merge below PR before all others, which will generate quite some conflicts I'm afraid.

  • https://github.com/CnCNet/xna-cncnet-client/pull/341

Rans4ckeR avatar Sep 15 '22 20:09 Rans4ckeR

I think it would be beneficial if you reset your branch to pre-fix and then reapply all warning fixes.

Metadorius avatar Sep 19 '22 17:09 Metadorius

@Metadorius Yes, I'll do it a little later

Belonit avatar Sep 19 '22 17:09 Belonit

I updated this PR and consider it is done

Belonit avatar Oct 22 '22 07:10 Belonit

Nightly build for this pull request:

  • artifacts.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

github-actions[bot] avatar Nov 11 '22 10:11 github-actions[bot]

The council ™️ concluded that the style checks should absolutely NOT fail a workflow. Instead look into making a problem matcher and registering it so that it displays issues as inline annotations (same applies for Phobos one as it's quite annoying to get failed runs just because of a stray trailing space): https://github.com/actions/toolkit/blob/main/docs/problem-matchers.md

Currently, GitHub Actions limit the annotation count in a workflow run.

  • 10 warning annotations, 10 error annotations, and 10 notice annotations per step
  • 50 annotations per job (sum of annotations from all the steps)
  • 50 annotations per run (separate from the job annotations, these annotations aren’t created by users)

If your workflow may exceed these annotation counts, consider filtering of the log messages which the Problem Matcher is exposed to (e.g. by PR touched files, lines, or other).

Belonit avatar Nov 25 '22 00:11 Belonit

I think those counts are reasonable and we can work with that. Not sure why you closed the PR though?

Metadorius avatar Nov 25 '22 00:11 Metadorius

I think those counts are reasonable and we can work with that. Not sure why you closed the PR though?

I'm not sure why it closed either. Possibly missclick

Belonit avatar Nov 25 '22 00:11 Belonit