xna-cncnet-client icon indicating copy to clipboard operation
xna-cncnet-client copied to clipboard

Published 20 hours ago • verified publisher icon CnCNet

Implement advanced player statuses indicator

Open Metadorius opened this issue 4 years ago • 5 comments

This pull request implements player slot indicators which show more information than simply ready or not ready.

example

Supported states are:

  • Empty
  • Unavailable
  • AI
  • Not Ready,
  • Ready
  • In Game
  • Warning
  • Error

Metadorius avatar Aug 22 '21 15:08 Metadorius

Everything seems to look good to me. There's a lot of commented out code that can probably just be removed.

There are conflicts with the latest Rampa libraries.

Do we need to theme the icons for the various YR themes? (I'll offer to do so, if the answer is yes).

devo1929 avatar Sep 15 '21 23:09 devo1929

@Metadorius I've created themed icons for all of the ones you have here for the YR client: https://github.com/CnCNet/cncnet-yr-client-package/pull/61

devo1929 avatar Oct 13 '21 22:10 devo1929

There are conflicts with the latest Rampa libraries.

The used XNAIndicator is already merged, so we can safely use upstream library version.

Do we need to theme the icons for the various YR themes? (I'll offer to do so, if the answer is yes).

Yes, sure, sorry for not responding earlier. The icons you've made look nice, good job.

Metadorius avatar Oct 24 '21 11:10 Metadorius

Nightly build for this pull request:

  • artifacts.zip This comment is automatic and is meant to allow guests to get latest automatic builds without registering. It is updated on every successful build.

github-actions[bot] avatar Mar 13 '22 20:03 github-actions[bot]

Waiting for TSC config as the default one and fixed develop branch.

Metadorius avatar Mar 14 '22 09:03 Metadorius