fix location constraint bug 1791791

[daaitudian]

Hi: In this Pr, I made some fixes for the #235

[knet-ci-bot]

Can one of the admins verify this patch?

[tomjelinek]

test this please

[daaitudian]

Thank for your reply. When I see this issue, I thought it was mean to add a [node] option for rule command to make sure the specific resource can run in the node under the rule. Since [node] option is not required in this command, so how would you like to fix this issue?

[tomjelinek]

how would you like to fix this issue?

The correct way is to analyze the constraint rule and check if it contains any node expressions (defined, not_defined, lt, gt, lte, gte, eq, ne). If it doesn't, print a warning. The check cannot be implemented simply, e.g. "lt" in rule. It needs to understand the rule structure to avoid cases when lt is used in a date expression or not as an operator.

[daaitudian]

Ok, thanks for your explanation. I will modify it later.