booth icon indicating copy to clipboard operation
booth copied to clipboard

Published 20 hours ago • verified publisher icon ClusterLabs

Fix a segfault + related refactoring

Open jnpkrn opened this issue 8 years ago • 4 comments

jnpkrn avatar Sep 13 '16 19:09 jnpkrn

Note that Travis CI runs are currently borked. There must have been a change on their side that is causing this, I can't even successfully finish what was once passing:

  • original: https://travis-ci.org/ClusterLabs/booth/builds/144114208
  • my test: https://travis-ci.org/jnpkrn/booth/builds/159707146

May they have mangled with 127.0.0.1 address resolution?

jnpkrn avatar Sep 13 '16 20:09 jnpkrn

There was an issue with last commit in not resolving local even if it is relied upon later on (hence introducing similar issue this PR aims to solve in the first place). That should be fixed now.

jnpkrn avatar Sep 14 '16 11:09 jnpkrn

Well, haven't read correctly, it was actually 127.0.1.1 and the proposed workaround for the indeed changed Travis CI image is #51. You may pull that first and then rerun tests for this PR.

jnpkrn avatar Sep 14 '16 13:09 jnpkrn

On Tue, Sep 13, 2016 at 12:58:56PM -0700, Jan Pokorný wrote:

  • Refactor: call find_site_by_name just once, up the stream

I did consider this before, but decided against refactoring. The new code which ends in setup_config() is somewhat unwieldy and difficult to grasp. Anyway, if you're bothered by this, a macro of a "if (!find_site_by_name(...)) { ... }" would probably be a better option.

dmuhamedagic avatar Sep 19 '16 08:09 dmuhamedagic