PAF icon indicating copy to clipboard operation
PAF copied to clipboard

Main

Open sjstoelting opened this issue 4 years ago • 3 comments

Hi all, I switched the naming to primary and secondary in documentations, comments, and log messages to get rid of the abusing terms.

This has to be done for some variables, too. But that will require more work and, obviously, more testing.

Just to let you know, I am using "main" in all my projects instead of the abusing term.

Regards, Stefanie

sjstoelting avatar Jan 12 '21 13:01 sjstoelting

Hi,

I already did a first round some week/month ago, mainly on the website part and kept the code part for later. So this help is greatly appreciated, thanks!

I'll review soon.

ioguix avatar Jan 12 '21 15:01 ioguix

HI, Thanks for the appreciation ;) I did not change variable names in the comments, because I thought, that should be part of a variable change.

Just to let you know.

sjstoelting avatar Jan 12 '21 16:01 sjstoelting

So I had a closer look. Most of the changes are straight forward, but some are not.

The Pacemaker project tries itself to improve its wording using promotable clones and promotion scores, but some keywords are still remaining here and there in conf, variables or commands on their side: https://www.clusterlabs.org/pacemaker/doc/en-US/Pacemaker/2.0/html/Pacemaker_Explained/s-resource-promotable.html

I pushed a commit to your branch to fix various technical wording and one bug related to the recover_master cluster attribute.

I would like to hold a bit more this PR to review it again before merging, with fresh eyes.

Thanks

ioguix avatar Jan 28 '21 18:01 ioguix