ClusterDuck-Protocol icon indicating copy to clipboard operation
ClusterDuck-Protocol copied to clipboard

Clean up startReceive

Open rolsen opened this issue 3 years ago • 1 comments

Duck has startReceive and DuckRadio has startReceive. Duck's version calls duckesp::restartDuck() if there's an error from lora.startReceive(), but DuckRadio's version doesn't.

It makes the most sense to me to have DuckRadio be the only object that can startReceive, and to have it take any restart/mitigation steps as needed.

I imagine startReceive is unlikely to return an error assuming there's no synchronization issues (where startReceive is called when transmit() is in progress, for example, though I didn't test that).

rolsen avatar Jul 29 '21 16:07 rolsen

This should be moved to DuckRadio

nfeuer avatar Oct 04 '21 18:10 nfeuer

This has been fixed for quite some time now.

amirna2 avatar Mar 06 '24 20:03 amirna2