bemenu icon indicating copy to clipboard operation
bemenu copied to clipboard

Feat: fuzzy matching flag -z

Open wintermute-cell opened this issue 1 year ago • 1 comments

Adds the option to use fuzzy matching when filtering menu items, along with the necessary flag and usage info.

Port of / strongly inspired by: https://tools.suckless.org/dmenu/patches/fuzzymatch/dmenu-fuzzymatch-4.6.diff

Would close https://github.com/Cloudef/bemenu/issues/367

wintermute-cell avatar Nov 20 '24 01:11 wintermute-cell

Bumping this, totally works and no issues

m0tholith avatar Dec 29 '24 07:12 m0tholith

@Cloudef could you review this please?

bitkeen avatar Aug 21 '25 00:08 bitkeen

Sorry for taking so long. It looks good to me.

Cloudef avatar Aug 21 '25 16:08 Cloudef

thank you!

wintermute-cell avatar Aug 22 '25 10:08 wintermute-cell

Hello, I reverted these changes because static analysis found bugs in the code. The CI probably did not find those because it was running older version of the compiler at the time of PR. Also, I think this feature should be implemented as separate function rather than in the default filter_dmenu_fun as dmenu has mechanism for selectable filters here https://github.com/Cloudef/bemenu/blob/master/lib/menu.c#L44-L47. If you send a revised PR, I'll review it again.

Cloudef avatar Aug 29 '25 08:08 Cloudef