CloudNet icon indicating copy to clipboard operation
CloudNet copied to clipboard

feat: enhance sign module compat with new minecraft versions

Open derklaro opened this issue 6 months ago • 1 comments

Motivation

New minecraft versions introduced new sign types and options that aren't yet supported in the sign module. These are:

  1. hanging signs (facing wasn't determined correctly yet for all sign types) 2, sign text from both sides of a sign (relevant for hanging signs)

Modification

  1. Replace usage of reflexion with bare method handles. This allows for better performance which is relevant as all methods in BukkitCompatibility are called on the main server thread.
  2. Support retrieval of sign faces for all types of signs.
  3. Support the new SignSide bukkit api and apply text (and other options) to both sides of a sign instead of just the front.

Result

Sign changes in recent minecraft/bukkit versions are now supported by the signs module.

derklaro avatar Jun 21 '25 15:06 derklaro

Test Results

 56 files  ±0   56 suites  ±0   2m 27s ⏱️ -18s 566 tests ±0  566 ✅ ±0  0 💤 ±0  0 ❌ ±0  931 runs  ±0  931 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2792313e. ± Comparison against base commit 159486f3.

github-actions[bot] avatar Jun 21 '25 16:06 github-actions[bot]