CloudNet
CloudNet copied to clipboard
feat: enhance sign module compat with new minecraft versions
Motivation
New minecraft versions introduced new sign types and options that aren't yet supported in the sign module. These are:
- hanging signs (facing wasn't determined correctly yet for all sign types) 2, sign text from both sides of a sign (relevant for hanging signs)
Modification
- Replace usage of reflexion with bare method handles. This allows for better performance which is relevant as all methods in
BukkitCompatibilityare called on the main server thread. - Support retrieval of sign faces for all types of signs.
- Support the new
SignSidebukkit api and apply text (and other options) to both sides of a sign instead of just the front.
Result
Sign changes in recent minecraft/bukkit versions are now supported by the signs module.
Test Results
56 files ±0 56 suites ±0 2m 27s ⏱️ -18s 566 tests ±0 566 ✅ ±0 0 💤 ±0 0 ❌ ±0 931 runs ±0 931 ✅ ±0 0 💤 ±0 0 ❌ ±0
Results for commit 2792313e. ± Comparison against base commit 159486f3.