cloud-health-connect icon indicating copy to clipboard operation
cloud-health-connect copied to clipboard

Published 20 hours ago • verified publisher icon CloudNativeJS

Fix: TS error declared but never read

Open DavidSint opened this issue 3 years ago • 4 comments

When noUnusedParams is enabled, errors are found e.g. error TS6133: 'req' is declared but its value is never read.. This commit adds an _ before these variable names as requested by @woozie.

resolves #95

DavidSint avatar May 03 '22 16:05 DavidSint

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 03 '22 16:05 CLAassistant

Hi! any updates on this fix? @BethGriggs @andrewhughes101 could you release it please?

zemd avatar Jul 01 '22 16:07 zemd

Hi! any updates on this fix? @BethGriggs @andrewhughes101 could you release it please?

I don't have any updates, but I understand that this package is a bit old now and perhaps should be archived.

The new guidance for health checks can be found in the node reference architecture which can be found here: https://github.com/nodeshift/nodejs-reference-architecture/blob/main/docs/operations/healthchecks.md

DavidSint avatar Jul 02 '22 12:07 DavidSint

the package still follows the guidance though, but anyway thanks for you reply 👍

zemd avatar Jul 02 '22 17:07 zemd