appmetrics-zipkin icon indicating copy to clipboard operation
appmetrics-zipkin copied to clipboard

Published 20 hours ago • verified publisher icon CloudNativeJS

Make timeout configurable

Open Igor-lkm opened this issue 5 years ago • 2 comments

Problem: on some environments default timeout from tcp-ping probe (5000ms) is not enough.

This PR would replace probe with ping and introduced optional timeout, by default equal to 5000ms as before.

Igor-lkm avatar Jul 25 '19 12:07 Igor-lkm

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 25 '19 12:07 CLAassistant

Also there were some problems with tests, caused by latency/delays, when tests are executed on travic-ci.

in waitAndGetTraces 1000ms is not enough to get results, work stable with 2000ms. Before the request we need to connect successfully to zipkin. As there is no way we can find it out (event or promise returned) make sense to add startupDelay to give appmetrics-zipkin package time to connect.

Igor-lkm avatar Jul 25 '19 14:07 Igor-lkm