evalai-cli icon indicating copy to clipboard operation
evalai-cli copied to clipboard

Published 20 hours ago • verified publisher icon Cloud-CV

Fix #243 Added module file for text_styling in utils

Open ShubhamPandey28 opened this issue 5 years ago • 3 comments

Added text_styling.py which solves both issue #234 and #243 at the same time.

ShubhamPandey28 avatar Jan 11 '20 17:01 ShubhamPandey28

@ShubhamPandey28 Great work on the issue and kudos on your first PR for CloudCV! 🎉 I loved how you tried to generalize everything in one function. The readability of the code is good as well.

I have left a few queries, so please have a look.

nikochiko avatar Jan 11 '20 19:01 nikochiko

Also, please let me know why you chose a single method instead of several helper methods. I was thinking of having several helper methods, so we could add them as we like. So, if we use flags as mentioned and the number of states increases, maintaining the code becomes more difficult.

nikochiko avatar Jan 11 '20 19:01 nikochiko

the helper functions will be very similar in that case. But you are right, it will be more easy to maintain with those helper functions.

ShubhamPandey28 avatar Jan 11 '20 20:01 ShubhamPandey28