Origami icon indicating copy to clipboard operation
Origami copied to clipboard

Published 20 hours ago • verified publisher icon Cloud-CV

Zipfile bug

Open ghost opened this issue 5 years ago • 4 comments

Error while downloading bundle in step two of demo registeration.

Description

hashlib md5 was not used correctly. Changed it and now zip file is downloaded.

Related Issue

Reviewers

@vpn1997

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other

Screenshots (if appropriate):

Checklist:

  • [x] My code follows the code style (modified PEP8) of this project.
  • [ ] I have updated the documentation accordingly.
  • [x] The code has been tested locally.

ghost avatar Jan 15 '19 14:01 ghost

@akata01 There are some deletions in the PR, is it necessary?

gautamjajoo avatar Jan 15 '19 14:01 gautamjajoo

@gautamjajoo while testing locally when i downloaded the zip file, bundles folder was created inside media folder so i accidentally committed those bundles too and they had nothing to do with the PR, so i deleted them and made the second commit. The actual bug fix is just one line of code replacement.

The deletions are misleading, let me just make a cleaner commit.

ghost avatar Jan 15 '19 20:01 ghost

hash_=md5.new() NameError: name 'md5' is not defined @akata01 isn't this PR this rectifying the above given issue. I hope reviewers will merge this ASAP

kurianbenoy avatar Jan 19 '19 02:01 kurianbenoy

@kurianbenoy yes it is fixing "md5 not defined" issue when we try to download zip file in the second step of demo registration.

ghost avatar Jan 19 '19 03:01 ghost