Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Fabrik is built with DEBUG settings

Open TimVanMourik opened this issue 6 years ago • 1 comments

To reproduce:

  • Go to http://fabrik.cloudcv.org
  • Click on the GitHub Login button

Behaviour

Because the GitHub login throws an error, a Django debug page is shown and your environment variables are there to see for public. Nothing sensitive (no SECRET_KEY and all), but still.

Expected behaviour

An error 500 screen should be shown.

Suggested solution

Currently the production settings are probably using the regular settings file with DEBUG=True hard-coded in them: https://github.com/Cloud-CV/Fabrik/blob/master/settings/common.py line 14

Either make a separate production settings file or read the DEBUG setting from an environment variable: DEBUG=os.getenv('DEBUG', default_value)

TimVanMourik avatar Feb 13 '19 12:02 TimVanMourik

@TimVanMourik Can i work on this issue .

ajitesh-30 avatar May 04 '19 15:05 ajitesh-30