Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Add PyTorch support

Open utsavgarg opened this issue 7 years ago • 9 comments

PyTorch is a recent deep learning framework which has become quite popular for researchers and we want to add support for it in Fabrik. The backend for PyTorch should be independent of our other backends so that changes in one do not affect the other. Adding support for this would entail adding both import functionality (which converts the PyTorch file to our intermediate representation) and the export functionality (which does the conversion the other way around).

Deliverables

A basic setup that fulfils the following requirements:

  • [ ] Investigating whether it is better to use the existing Keras backend to handle the PyTorch import and export, or to have a separate backend for PyTorch
  • [ ] Adding support for PyTorch import and export for at least as many layers as are present in the Keras backend
  • [ ] Write unittests for the PyTorch backend

Please comment for if you have questions.

utsavgarg avatar Jan 28 '18 15:01 utsavgarg

@utsavgarg Import using Keras is implemented in #284, can the person working on this test and use that code, if they are implementing import/export using Keras?

PalashTanejaPro avatar Jan 30 '18 01:01 PalashTanejaPro

@PalashTanejaPro Sure.

utsavgarg avatar Jan 30 '18 02:01 utsavgarg

@utsavgarg Can I test the feasibility of using Keras's import for PyTorch implemented in #284 ?

thatbrguy avatar Feb 04 '18 07:02 thatbrguy

@Sayan98 Sure, go ahead.

utsavgarg avatar Feb 04 '18 14:02 utsavgarg

@utsavgarg @PalashTanejaPro @thatbrguy I would like to work on this , what all features has been already assigned ??

vasu-dev avatar Feb 25 '18 06:02 vasu-dev

@vasu-dev I'm waiting until the remote pytorch branch is updated with the master, after that i'll open a PR to add the basic folders and files where everyone can contribute. I'm mostly working on the import, it's better if you ask more details on the gitter channel.

thatbrguy avatar Feb 25 '18 06:02 thatbrguy

@utsavgarg @thatbrguy @PalashTanejaPro Has there been any progress on this issue? I want to work on this issue.

MuLx10 avatar Feb 25 '18 10:02 MuLx10

I also want to work on this issue on GSOC

mselimata avatar Mar 26 '18 10:03 mselimata

How is progress on this, especially with the release of PyTorch 1.0? Is there room to help still?

dwlsalmeida avatar Feb 05 '19 13:02 dwlsalmeida