[Fix #1347] Add feature to invite users to host team using URL
This PR is to resolve issue #1347 . The goal is to implement a feature that allows a host to invite a new team member to the host team by sending them a unique URL when their e-mail is entered.
Still some work to be done on this. I'll iterate on this PR and add features
Hey @Zahed-Riyaz , Is this ready to be reviewed?
Hi @RishabhJain2018 , just working on some final tweaks to ensure travis CI builds. The feature is working fine , I just need to write tests, will share a video of the feature soon.
Awesome, thanks for the update.
Also @RishabhJain2018 should I raise a separate PR for tests or include that in this PR?
A separate PR would be fine!
I think it should be good for review. Here's a video of the feature :
https://github.com/user-attachments/assets/27b4844b-8b7f-4a84-a566-427f13c5c288
Looks like travis CI failed to pass all the tests because it couldn't locate base.html as a template, which I configured in hosts/urls.py .
It is this way, so that when users click on invitation link (which does not start with api/hosts) , base.html is served as the entry point so that django doesn't handle the routing.
Solution to this might be including frontend templates in common.py DIRS , which contains base.html
Codecov Report
Attention: Patch coverage is 22.05882% with 106 lines in your changes missing coverage. Please review.
Project coverage is 74.89%. Comparing base (
96968d6) to head (f1aaa44). Report is 1218 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #4587 +/- ##
==========================================
+ Coverage 72.93% 74.89% +1.96%
==========================================
Files 83 22 -61
Lines 5368 3740 -1628
==========================================
- Hits 3915 2801 -1114
+ Misses 1453 939 -514
| Files with missing lines | Coverage Δ | |
|---|---|---|
| frontend/src/js/controllers/authCtrl.js | 96.08% <64.70%> (+29.22%) |
:arrow_up: |
| ...ntend/src/js/controllers/challengeHostTeamsCtrl.js | 66.95% <7.69%> (-4.73%) |
:arrow_down: |
| ...rollers/challengeHostTeamInvitationAcceptedCtrl.js | 16.98% <16.98%> (ø) |
... and 73 files with indirect coverage changes
| Files with missing lines | Coverage Δ | |
|---|---|---|
| frontend/src/js/controllers/authCtrl.js | 96.08% <64.70%> (+29.22%) |
:arrow_up: |
| ...ntend/src/js/controllers/challengeHostTeamsCtrl.js | 66.95% <7.69%> (-4.73%) |
:arrow_down: |
| ...rollers/challengeHostTeamInvitationAcceptedCtrl.js | 16.98% <16.98%> (ø) |
... and 73 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8ff4236...f1aaa44. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@RishabhJain2018 should be good to go now!
Hi @RishabhJain2018 , any updates on this?
@RishabhJain2018 should I make any further changes? Please let me know
Currently I'm in the process of writing tests (via #4624). So I'd like to take on another issue in the meantime
Hey @Zahed-Riyaz , Is this ready to review?
Hi @RishabhJain2018 yes this PR is good for review