EvalAI icon indicating copy to clipboard operation
EvalAI copied to clipboard

Fix #4524 Add test cases for host models

Open Zahed-Riyaz opened this issue 8 months ago • 6 comments

This PR is to fix #4524.

It covers the task list as mentioned in the issue and ensures complete coverage of the hosts/models.py file.

Zahed-Riyaz avatar Mar 29 '25 10:03 Zahed-Riyaz

Hi @RishabhJain2018 this PR is ready for review

Zahed-Riyaz avatar Mar 30 '25 12:03 Zahed-Riyaz

Thanks @Zahed-Riyaz for the PR. Let me fix the codecov so that I can track the progress too. Once that is fixed, I'll merge this.

RishabhJain2018 avatar Apr 01 '25 05:04 RishabhJain2018

Sure! Thank you for the update.

Zahed-Riyaz avatar Apr 01 '25 07:04 Zahed-Riyaz

Build wasn't successful because of code quality checks. Should be good now. (hopefully)

Zahed-Riyaz avatar May 02 '25 12:05 Zahed-Riyaz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.70%. Comparing base (96968d6) to head (cc0218c). Report is 1183 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4525      +/-   ##
==========================================
- Coverage   72.93%   69.70%   -3.23%     
==========================================
  Files          83       21      -62     
  Lines        5368     3608    -1760     
==========================================
- Hits         3915     2515    -1400     
+ Misses       1453     1093     -360     

see 65 files with indirect coverage changes

see 65 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d1444f...cc0218c. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 02 '25 13:05 codecov[bot]

Hi @RishabhJain2018 this can be merged now

Zahed-Riyaz avatar May 08 '25 05:05 Zahed-Riyaz