EvalAI icon indicating copy to clipboard operation
EvalAI copied to clipboard

Fix #3693 [FrontendV2] Added Validation for team url

Open Suryansh5545 opened this issue 4 years ago • 3 comments

Description This PR:-

  • [X] Fix the #3693 Url Validation bug.

A working GIF of the application below

Demo

Peek 2022-02-12 14-58

Suryansh5545 avatar Feb 12 '22 09:02 Suryansh5545

@Ram81 Working on it. seems like all the new pr builds are failing due to these two test FAILED tests/unit/challenges/test_views.py::PresignedURLAnnotationTest::test_finish_annotation_file_upload FAILED tests/unit/jobs/test_views.py::PresignedURLSubmissionTest::test_finish_submission_file_upload

Suryansh5545 avatar Feb 12 '22 17:02 Suryansh5545

Codecov Report

Merging #3694 (0bee7ea) into master (96968d6) will decrease coverage by 1.40%. The diff coverage is 33.39%.

@@            Coverage Diff             @@
##           master    #3694      +/-   ##
==========================================
- Coverage   72.93%   71.53%   -1.41%     
==========================================
  Files          83       20      -63     
  Lines        5368     3235    -2133     
==========================================
- Hits         3915     2314    -1601     
+ Misses       1453      921     -532     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 15ec873...0bee7ea. Read the comment docs.

codecov-commenter avatar Feb 16 '22 13:02 codecov-commenter

@Ram81 The build is fixed. It was failing due to response library removing support for is_string. Moto 2.3.2 fixed this.

Suryansh5545 avatar Feb 16 '22 14:02 Suryansh5545