EvalAI icon indicating copy to clipboard operation
EvalAI copied to clipboard

Add edit option for submission guidelines and leaderboard description

Open gautamjajoo opened this issue 4 years ago • 6 comments

@Ram81 @Kajol-Kumari

Screenshot from 2021-08-14 22-24-58

gautamjajoo avatar Aug 14 '21 16:08 gautamjajoo

Codecov Report

Merging #3569 (16e5b2d) into master (96968d6) will decrease coverage by 1.40%. The diff coverage is 33.39%.

@@            Coverage Diff             @@
##           master    #3569      +/-   ##
==========================================
- Coverage   72.93%   71.53%   -1.41%     
==========================================
  Files          83       20      -63     
  Lines        5368     3235    -2133     
==========================================
- Hits         3915     2314    -1601     
+ Misses       1453      921     -532     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c37549...16e5b2d. Read the comment docs.

codecov-commenter avatar Aug 14 '21 17:08 codecov-commenter

We would have a separate section for this right? What should be the title of that seciton?

gautamjajoo avatar Aug 16 '21 05:08 gautamjajoo

We would have a separate section for this right? What should be the title of that section?

@gautamjajoo Instead of making a whole new section can we please keep these in a new row. Like we can keep Submission Guideline edit option in parallel with test annotation upload done in this PR

And we can keep Leaderboard Description edit option in a new row below the Leaderboard Visibility row

\cc: @Ram81 please share your thoughts on the same

Kajol-Kumari avatar Aug 23 '21 14:08 Kajol-Kumari

@Kajol-Kumari Actually we thought of buttons becuase initially it was done the way you have mentioned but it was felt that it is a part of phase selection that's why we changed it to buttons.

gautamjajoo avatar Aug 23 '21 14:08 gautamjajoo

Resolved the conflicts and here is the screenshot. Screenshot from 2021-08-20 22-51-09

gautamjajoo avatar Aug 27 '21 08:08 gautamjajoo

@Ram81 Can you please review this once more?

RishabhJain2018 avatar Sep 01 '21 19:09 RishabhJain2018