EvalAI icon indicating copy to clipboard operation
EvalAI copied to clipboard

Determine why code coverage is low

Open RishabhJain2018 opened this issue 5 years ago • 11 comments

Current Behaviour

The code coverage is 72% which is quite low.

Expected Behaviour

The code coverage should be > 90%.

Deliverable

  • [ ] Figure out the pieces of code for which the test cases are missing. (A link to google doc highlighting those sections in the comments would suffice for it.)

RishabhJain2018 avatar Jan 21 '19 23:01 RishabhJain2018

I would like to work on this one. @RishabhJain2018

KhalidRmb avatar Jan 22 '19 00:01 KhalidRmb

Sure! You can take this up.

RishabhJain2018 avatar Jan 22 '19 01:01 RishabhJain2018

@RishabhJain2018 @KhalidRmb #1997 is related to this issue.

krtkvrm avatar Jan 22 '19 14:01 krtkvrm

Thanks, @vkartik97 for mentioning it. @KhalidRmb Please do take a note of it in the doc you are preparing.

RishabhJain2018 avatar Jan 23 '19 00:01 RishabhJain2018

@RishabhJain2018 Link to Google doc with a checklist of all the relevant unit tests to be written: https://docs.google.com/document/d/1IF3APjd93hUeov4KKRGDupMlcjpLO-MYo3_lEP8e42k/edit?usp=sharing

KhalidRmb avatar Jan 25 '19 19:01 KhalidRmb

@RishabhJain2018 ..any comments/changes required to the doc?

KhalidRmb avatar Jan 26 '19 17:01 KhalidRmb

@KhalidRmb @RishabhJain2018 I will create an issue and write unit tests for /apps/base/utils.py because #2054 couldn't pass the coverage tests.

yongzx avatar Feb 10 '19 17:02 yongzx

@KhalidRmb Added unit tests for both functions decode_data and encode_data in /apps/base/utils.py #2107

yongzx avatar Feb 10 '19 20:02 yongzx

scripts/workers/submission_worker.py is a major area where Test coverage can be improved @KhalidRmb . I guess python unit tests can do the job for submission worker. Yet we also need to think where Integration tests are missing in apps to increase coverage

kurianbenoy avatar Feb 28 '19 13:02 kurianbenoy

i would like to work on this @RishabhJain2018

01shriyansh avatar Nov 08 '21 16:11 01shriyansh

i would like to work on this @RishabhJain2018

adithyathecoder avatar Jan 23 '22 16:01 adithyathecoder