EvalAI-ngx icon indicating copy to clipboard operation
EvalAI-ngx copied to clipboard

Fix #190: Replace template driven form in auth pages with app input component

Open danielrs975 opened this issue 4 years ago • 1 comments

Fixes #190 Replace template driven form in reset-password-confirm page with app input component

Changes proposed in this pull request:

  • Change the template driven form in the Login Page
  • Change the template driven form in the reset-password page
  • Change the template driven form in the Sign Up page
  • Link to live demo: http://pr-190-evalai.surge.sh

danielrs975 avatar Mar 22 '20 22:03 danielrs975

Codecov Report

Merging #307 into master will increase coverage by 0.22%. The diff coverage is 40.54%.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   50.62%   50.84%   +0.22%     
==========================================
  Files          66       66              
  Lines        3771     3790      +19     
  Branches      444      442       -2     
==========================================
+ Hits         1909     1927      +18     
- Misses       1767     1769       +2     
+ Partials       95       94       -1     
Impacted Files Coverage Δ
src/app/services/global.service.ts 38.19% <0.00%> (ø)
...ts/auth/reset-password/reset-password.component.ts 56.25% <39.13%> (+4.63%) :arrow_up:
src/app/components/auth/signup/signup.component.ts 44.73% <42.46%> (-0.04%) :arrow_down:
...rc/app/components/utility/input/input.component.ts 58.87% <44.44%> (+2.87%) :arrow_up:
src/app/components/auth/login/login.component.ts 57.14% <50.00%> (+5.29%) :arrow_up:
...bliclists/challengelist/challengelist.component.ts 47.57% <0.00%> (+0.97%) :arrow_up:
Impacted Files Coverage Δ
src/app/services/global.service.ts 38.19% <0.00%> (ø)
...ts/auth/reset-password/reset-password.component.ts 56.25% <39.13%> (+4.63%) :arrow_up:
src/app/components/auth/signup/signup.component.ts 44.73% <42.46%> (-0.04%) :arrow_down:
...rc/app/components/utility/input/input.component.ts 58.87% <44.44%> (+2.87%) :arrow_up:
src/app/components/auth/login/login.component.ts 57.14% <50.00%> (+5.29%) :arrow_up:
...bliclists/challengelist/challengelist.component.ts 47.57% <0.00%> (+0.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3d23ca...82bb0c4. Read the comment docs.

codecov-io avatar Mar 22 '20 22:03 codecov-io