EvalAI-ngx icon indicating copy to clipboard operation
EvalAI-ngx copied to clipboard

Add a soft check when editing phase details

Open nikochiko opened this issue 5 years ago • 2 comments

As part of a Google Code-In task.

Changes proposed in this pull request:

  • Include a soft-check to ensure that the host does not enter: max submissions/day > max number of submissions/month > Max total submissions
  • Link to live demo: http://pr-265-evalai.surge.sh

nikochiko avatar Jan 07 '20 16:01 nikochiko

Codecov Report

Merging #265 into master will decrease coverage by 0.1%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
- Coverage   50.62%   50.51%   -0.11%     
==========================================
  Files          66       66              
  Lines        3761     3771      +10     
  Branches      442      444       +2     
==========================================
+ Hits         1904     1905       +1     
- Misses       1762     1771       +9     
  Partials       95       95
Impacted Files Coverage Δ
...ephases/editphasemodal/editphasemodal.component.ts 33.76% <0%> (-5.04%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.61% <0%> (+0.95%) :arrow_up:
Impacted Files Coverage Δ
...ephases/editphasemodal/editphasemodal.component.ts 33.76% <0%> (-5.04%) :arrow_down:
...bliclists/challengelist/challengelist.component.ts 47.61% <0%> (+0.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e81fb10...2a90aa2. Read the comment docs.

codecov-io avatar Jan 07 '20 16:01 codecov-io

@Ram81 I am facing this issue for the dev build :confused: https://github.com/Cloud-CV/EvalAI-ngx/issues/249. Can you please share if there is any other way to test the working?

(Not linking issue directly as it could create reference to the unrelated issue)

nikochiko avatar Jan 08 '20 16:01 nikochiko