EvalAI-ngx icon indicating copy to clipboard operation
EvalAI-ngx copied to clipboard

Increases code coverage

Open sanketbansal opened this issue 5 years ago • 2 comments

Changes proposed in this pull request:

  • Added Test cases for different components and services which had very low code coverage.
  • Link to live demo: http://pr-130-evalai.surge.sh

Screenshot from 2019-05-27 00-39-28

sanketbansal avatar May 27 '19 04:05 sanketbansal

Codecov Report

Merging #130 into master will increase coverage by 14.65%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #130       +/-   ##
===========================================
+ Coverage   53.38%   68.04%   +14.65%     
===========================================
  Files          55       55               
  Lines        2347     2347               
  Branches      253      253               
===========================================
+ Hits         1253     1597      +344     
+ Misses       1020      640      -380     
- Partials       74      110       +36
Impacted Files Coverage Δ
src/app/services/global.service.ts 44.5% <0%> (+3.29%) :arrow_up:
src/app/services/api.service.ts 74.57% <0%> (+3.38%) :arrow_up:
...nents/utility/selectphase/selectphase.component.ts 74.28% <0%> (+11.42%) :arrow_up:
src/app/services/endpoints.service.ts 82.25% <0%> (+16.12%) :arrow_up:
...ponents/publiclists/teamlist/teamlist.component.ts 59.74% <0%> (+24.52%) :arrow_up:
src/app/services/challenge.service.ts 58.15% <0%> (+26.95%) :arrow_up:
...lengeleaderboard/challengeleaderboard.component.ts 65.21% <0%> (+30.43%) :arrow_up:
...lengesubmissions/challengesubmissions.component.ts 71.11% <0%> (+35.55%) :arrow_up:
...bliclists/challengelist/challengelist.component.ts 78.65% <0%> (+38.2%) :arrow_up:
src/app/app.component.ts 75.4% <0%> (+39.34%) :arrow_up:
... and 3 more
Impacted Files Coverage Δ
src/app/services/global.service.ts 44.5% <0%> (+3.29%) :arrow_up:
src/app/services/api.service.ts 74.57% <0%> (+3.38%) :arrow_up:
...nents/utility/selectphase/selectphase.component.ts 74.28% <0%> (+11.42%) :arrow_up:
src/app/services/endpoints.service.ts 82.25% <0%> (+16.12%) :arrow_up:
...ponents/publiclists/teamlist/teamlist.component.ts 59.74% <0%> (+24.52%) :arrow_up:
src/app/services/challenge.service.ts 58.15% <0%> (+26.95%) :arrow_up:
...lengeleaderboard/challengeleaderboard.component.ts 65.21% <0%> (+30.43%) :arrow_up:
...lengesubmissions/challengesubmissions.component.ts 71.11% <0%> (+35.55%) :arrow_up:
...bliclists/challengelist/challengelist.component.ts 78.65% <0%> (+38.2%) :arrow_up:
src/app/app.component.ts 75.4% <0%> (+39.34%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d0711a...91e3764. Read the comment docs.

codecov-io avatar May 27 '19 04:05 codecov-io

@sanketbansal Please remove the conflicts from the master. @Shekharrajak @RishabhJain2018 should we merge this or keep it opened for now so that he could add more tests later?

lunayach avatar Jun 23 '19 14:06 lunayach