Cloud-CV
Created Error page
Changes proposed in this pull request:
- Added html-error component which is a parent component for error pages.
- Added server-error component for error 500.
- Refactor not-found component inside the parent component.
- Added routing for error pages.
- Link to live demo: http://pr-122-evalai.surge.sh
I checked the travis-build issue. It is giving errors for ng test command.
ng test --watch=false --progress=false --code-coverage > test-log.
Any idea??
Codecov Report
Merging #122 into master will increase coverage by
0.17%. The diff coverage is70.83%.
@@ Coverage Diff @@
## master #122 +/- ##
=========================================
+ Coverage 53.43% 53.6% +0.17%
=========================================
Files 55 58 +3
Lines 2360 2384 +24
Branches 253 255 +2
=========================================
+ Hits 1261 1278 +17
- Misses 1025 1031 +6
- Partials 74 75 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...components/errors/not-found/not-found.component.ts | 100% <ø> (ø) |
|
| src/app/components/errors/html-errors.component.ts | 100% <100%> (ø) |
|
| ...ents/errors/server-error/server-error.component.ts | 100% <100%> (ø) |
|
| src/app/services/global.service.ts | 40.95% <33.33%> (-0.26%) |
:arrow_down: |
| src/app/services/error-handler.service.ts | 70% <70%> (ø) |
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...components/errors/not-found/not-found.component.ts | 100% <ø> (ø) |
|
| src/app/components/errors/html-errors.component.ts | 100% <100%> (ø) |
|
| ...ents/errors/server-error/server-error.component.ts | 100% <100%> (ø) |
|
| src/app/services/global.service.ts | 40.95% <33.33%> (-0.26%) |
:arrow_down: |
| src/app/services/error-handler.service.ts | 70% <70%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update f9f802b...e8f821a. Read the comment docs.
@Shekharrajak.
- I created the PR as it has a different directory structure for error pages and new UI for error 500 component.
- There is no specific reason for naming to html-errors instead of error-page. U want me to update it?
- It redirects to errors for route "error/404" and "error/500".
Thanks for letting me know these points.
- I created the PR as it has a different directory structure for error pages and new UI for error 500 component.
- There is no specific reason for naming to html-errors instead of error-page. U want me to update it?
yes, that I saw. I see that AngularJS project have directory name error-page, so it will be better to make it consistent.
- It redirects to errors for route "error/404" and "error/500".
Why not you start working on adding logic for it. It should be functional when backend server crashes/sending 500 status code/not found status for the request.
@lunayach @Shekharrajak Can you guys please review this PR and get it merged.
I don't see reply for my review comments above so I am not reviewing it again and assuming it was not read.
@Shekharrajak I have completed the changes in the PR. Tell me if there is some other changes required to be done.
I don't see a reply for #122 (review) comment and commits from PR #104
@Shekharrajak I did not cherrypicked the commit of #104 because this PR has already similar commits present. Tell me if it is required. I will do that.
Cherry picking means - You are reserving the original author and authentication of commit (rather than copying the code and using it).
@Shekharrajak I did not cherrypicked the commit of #104 because this PR has already similar commits present.
I don't see Interceptor logic in this PR. Please let me know what are the things you see similar (except this)
@Shekharrajak, I have rebased this PR with #104. Now, should I drop some similar changes present after rebasing like internal server error page?
Yes! now you can do your changes top of it. Please have a look, into the comments