EvalAI-ngx icon indicating copy to clipboard operation
EvalAI-ngx copied to clipboard

[WIP] GSoC Idea - Add 500 error page

Open Shekharrajak opened this issue 5 years ago • 7 comments

Fixes # GSoC Idea - Add 500 error page

Changes proposed in this pull request:

  • if there is any HTTP request is sent from the Angular application and response it 500 status code, it will redirect to 500 page (InternalServerComponent)
  • Link to live demo: http://pr-XXX-evalai.surge.sh

500

TODOs / Future work :

  • [ ] For error-page a separate module can be created and imported to app module for lazy loading.
  • [ ] error-page uses a service that redirect to 500 page , similar things can be done for 404, 400 or other status code.
  • [ ] move the not-found component in error-page folder.
  • [ ] services related to errors and error handler can be rearranged in one folder.
  • [ ] Write testcase for the changes

Shekharrajak avatar Mar 15 '19 13:03 Shekharrajak

I have created a PR #122 for the proposed changes. please have a look.

sanketbansal avatar Apr 06 '19 16:04 sanketbansal

@Shekharrajak Is this PR complete or still WIP?

RishabhJain2018 avatar May 09 '19 06:05 RishabhJain2018

@RishabhJain2018 , I think, @sanketbansal should cherry-pick commits from this branch and merge(rebase) it with #122 . Then @sanketbansal can do his changes(may be his the UI page work for 500) and add testcases for it.

Shekharrajak avatar May 09 '19 06:05 Shekharrajak

Cool. @sanketbansal Can you please make sure that you don't forget this.

RishabhJain2018 avatar May 09 '19 06:05 RishabhJain2018

yeah, I have checked this PR but it has no as such commits to be cherrypicked for #122 as many changes have already been committed in #122 which are quite similar to this PR.

sanketbansal avatar May 16 '19 19:05 sanketbansal

Although, if it is required then I can do that.

sanketbansal avatar May 16 '19 19:05 sanketbansal

It looked like you saw the Rishabh's comment today. I replied here, please have a look.

Shekharrajak avatar May 17 '19 05:05 Shekharrajak